Drupal Commerce Issue Queue

Add Albanian Leke to Currencies

Thu, 06/19/2014 - 07:31

Hi,

Can you please add the Albanian Lek to the default Currencys? It would be very nice.
http://en.wikipedia.org/wiki/ISO_4217

Code: ALL
Num: 008
E: 2
Currency: Albanian lek
Country: Albania

Thank You very much in Advance

Categories: Issue Queues

Allow for VAT to be required

Wed, 06/18/2014 - 02:51

Hello,

If one of our employees would forget to set a VAT configuration for a product, we would have a huge issue with our bookkeeping and the tax office.

Please allow for the administrator/developer to configure whether tax (VAT in our case) should be required for required commerce_price fields.

Our temporary solution right now:

      $element['include_tax'] = array(
        '#type' => 'select',
        '#title' => t('Include tax in this price'),
        '#description' => t('Saving prices tax inclusive will bypass later calculations for the specified tax.'),
        '#options' => count($options) == 1 ? reset($options) : $options,
        '#default_value' => $default,
        '#required' => FALSE,
        '#empty_value' => '',
        '#suffix' => '<div class="commerce-price-tax-included-clearfix"></div>',
        '#attached' => array(
          'css' => array(drupal_get_path('module', 'commerce_tax') . '/theme/commerce_tax.theme.css'),
        ),
      );
      // Require tax if price is required
      if ($context['instance']['required'] == TRUE) {
        $element['include_tax']['#required'] = TRUE;
      }
    }

Maybe a checkbox in the tax configuration can specify if this feature should be enabled or not?

Best Regards

Per Eriksson

Categories: Issue Queues

Allow for VAT to be required

Wed, 06/18/2014 - 02:51

Hello,

If one of our employees would forget to set a VAT configuration for a product, we would have a huge issue with our bookkeeping and the tax office.

Please allow for the administrator/developer to configure whether tax (VAT in our case) should be required for required commerce_price fields.

Our temporary solution right now:

      $element['include_tax'] = array(
        '#type' => 'select',
        '#title' => t('Include tax in this price'),
        '#description' => t('Saving prices tax inclusive will bypass later calculations for the specified tax.'),
        '#options' => count($options) == 1 ? reset($options) : $options,
        '#default_value' => $default,
        '#required' => FALSE,
        '#empty_value' => '',
        '#suffix' => '<div class="commerce-price-tax-included-clearfix"></div>',
        '#attached' => array(
          'css' => array(drupal_get_path('module', 'commerce_tax') . '/theme/commerce_tax.theme.css'),
        ),
      );
      // Require tax if price is required
      if ($context['instance']['required'] == TRUE) {
        $element['include_tax']['#required'] = TRUE;
      }
    }

Maybe a checkbox in the tax configuration can specify if this feature should be enabled or not?

Best Regards

Per Eriksson

Categories: Issue Queues

Pane weight: separating display from processing

Tue, 06/17/2014 - 03:02

Good morning,

Few month ago, I spotted a "lack of feature" that would lead to failing behavior on cart: https://drupal.org/node/2138463.

When using PayPal WPP, it seems that commerce_paypal_wpp_submit_form_submit is called before the billing data is set or before the order data is updated.

Final explanation I came up with is

in commerce pages, the order of the panes, set for instance using the backend UI, is used for
a) the order of the rendering in the frontend .. kind of expected behavior
b) the order of the processing in the backend on "Next" action
(next being any action that move forward: next, purchase, ...)

(b) is IMHO wrong as we should be able to set different values for them:
a) is for the display so let's call it "design weight"
b) is for the processing so let's call it "processing weight"

What do you think about this?

Categories: Issue Queues

Pane weight: separating display from processing

Tue, 06/17/2014 - 03:02

Good morning,

Few month ago, I spotted a "lack of feature" that would lead to failing behavior on cart: https://drupal.org/node/2138463.

When using PayPal WPP, it seems that commerce_paypal_wpp_submit_form_submit is called before the billing data is set or before the order data is updated.

Final explanation I came up with is

in commerce pages, the order of the panes, set for instance using the backend UI, is used for
a) the order of the rendering in the frontend .. kind of expected behavior
b) the order of the processing in the backend on "Next" action
(next being any action that move forward: next, purchase, ...)

(b) is IMHO wrong as we should be able to set different values for them:
a) is for the display so let's call it "design weight"
b) is for the processing so let's call it "processing weight"

What do you think about this?

Categories: Issue Queues

Views Taxonomy Page does not show Products tagged with child-term?

Fri, 06/13/2014 - 18:06

Hi,

I am trying to use taxonomy to catalog my products. Say I have a catalog with following structure:

Clothing (term id = 1)
- Hat (term id = 2)
- Shirt (term id = 3)

And I two products: "myhat" labeled as term "Hat", and "myshirt" labeled as term "Shirt", and of course I have two display nodes: "myhat-display" and "myshirt-display". (here, I only have one product type, and one product display content type)

After creating my page view with path: taxonomy/term/%

on page: taxonomy/term/2, and page taxonomy/term/3, I have no problem showing "myhat-display" and "myshirt-display"

However, the page: taxonomy/term/1, shows nothing, which should be showing both "myhat-display" and "myshirt-display".

BTW, in my views page, I set the Contextual filters and Relationships as follows:

Contextual filters
(Products referenced by field_general_product) Commerce Product: Product Catalog

Relationships
Content: general_product

Any idea what the problem is, and how to solve it?

Categories: Issue Queues

Allow the Product controller to keep a pre-determined revision_uid

Tue, 06/10/2014 - 11:33

In the commerce_product entity controller, revision_uid is being set to the global user uid without a check to see if it is already set. If the revision_uid is set programmatically, it should be kept as is. Patch attached.

Categories: Issue Queues

Allow the Product controller to keep a pre-determined revision_uid

Tue, 06/10/2014 - 11:33

In the commerce_product entity controller, revision_uid is being set to the global user uid without a check to see if it is already set. If the revision_uid is set programmatically, it should be kept as is. Patch attached.

Categories: Issue Queues

Failed to Rearrage Product Image field

Tue, 06/10/2014 - 11:29

Hi,

I am playing with drupal commerce, while having following problem:

What I did:

1) created a product type (T-Shirt) with taxonomy attributes and product image field;
2) rearranged the product type fields through manage display, and moved product image field on top of attributes (color, size).
3) created a product display node, referencing all variations of my T-Shirt product.

Here is the problem:

the product image is shown below the product attributes, which is not desired.

Attached please find screenshots for the problem.

Any ideas?

Thanks.

Categories: Issue Queues

hook_commerce_tax_type_calculate_rates break ajax request on checkout page

Tue, 06/10/2014 - 06:43

Hello,

I'm working on a custom module for calculate VAT on prices provided by Customizable product.
So, i use hook_commerce_tax_type_calculate_rates but if when i want work around $line_item or $tax_type variables, thats seems ajax request (changing country or using a coupon) are broken (Error 200).

Some body coul'd help me to use this hook properly ?

This a very simplified code, but it's enought for ajax breaking.

<?php
function tva_cousin_commerce_tax_type_calculate_rates($tax_type, $line_item) {
    drupal_set_message($line_item->line_item_label, 'status', FALSE);
}
?>

Thanks a lot !

Categories: Issue Queues

Difference Between Taxonomy based Catalog and Product Type

Mon, 06/09/2014 - 16:37

Hi,

I am currently learning to build a e-commerce site with drupal commerce module, and getting very confused with Taxonomy based catalog and Product type.

First of all, I assume that taxonomy terms should be used for cataloging, especially for a site selling various kinds products, such as amazon.

However, given the concept of "Product Type", seems to me that both Taxonomy terms and Product type can be used for cataloging. For example, I can have "T-shirt" as either a taxonomy term or a specific product type.

So, what is the best practice then? If I am going to use Taxonomy terms for cataloging, what should I do with "Product Type"?

Thanks in advance.

Categories: Issue Queues

Having an autocomplete field on a checkout pane breaks the continue button when selecting with the enter key

Mon, 06/09/2014 - 06:07

When you have an autocomplete field on a checkout page selecting an option breaks the continue button because the throbber keeps spinning.

Putting a return in Drupal.behaviors.commerceCheckout resolves the issue for the moment but is not a solution. Needs more investigating...

Categories: Issue Queues

Having an autocomplete field on a checkout pane breaks the continue button when selecting with the enter key

Mon, 06/09/2014 - 06:07

When you have an autocomplete field on a checkout page selecting an option breaks the continue button because the throbber keeps spinning.

Putting a return in Drupal.behaviors.commerceCheckout resolves the issue for the moment but is not a solution. Needs more investigating...

Categories: Issue Queues

Cannot change a line items display

Fri, 06/06/2014 - 12:49

I am trying to add a wrapper around a line item however it is not being added when I add it in the manage display of the line item in question. In fact nothing is working in the Manage Display of that line item, even if I hide a label for a particular field it still shows up where the product is. Is this a bug? How do I fix this?

Categories: Issue Queues

Cannot change a line items display

Fri, 06/06/2014 - 12:49

I am trying to add a wrapper around a line item however it is not being added when I add it in the manage display of the line item in question. In fact nothing is working in the Manage Display of that line item, even if I hide a label for a particular field it still shows up where the product is. Is this a bug? How do I fix this?

Categories: Issue Queues

Permit settings.php override of payment method configuration

Wed, 06/04/2014 - 14:58

I don't believe this is a feature of Commerce currently. #2157789: Test Mode implements a form of it for Commerce Stripe, but it would be great if we could import the model to Commerce architecture and not have each payment method implement it separately.

With Ubercart payment processors, it is possible to lock test mode credentials in settings.php using the $conf array. Since Commerce payment method config is stored in Rules rather than variables, this is no longer a feature of Commerce payments.

The advantage to this was that a development site could lock test creds in, have a copy of the live DB loaded, and start processing test transactions. The lack of this feature means that configuring the payment method(s) is required each time the DB is reloaded (or other special handling is required).

Categories: Issue Queues

Permit settings.php override of payment method configuration

Wed, 06/04/2014 - 14:58

I don't believe this is a feature of Commerce currently. #2157789: Test Mode implements a form of it for Commerce Stripe, but it would be great if we could import the model to Commerce architecture and not have each payment method implement it separately.

With Ubercart payment processors, it is possible to lock test mode credentials in settings.php using the $conf array. Since Commerce payment method config is stored in Rules rather than variables, this is no longer a feature of Commerce payments.

The advantage to this was that a development site could lock test creds in, have a copy of the live DB loaded, and start processing test transactions. The lack of this feature means that configuring the payment method(s) is required each time the DB is reloaded (or other special handling is required).

Categories: Issue Queues

Check number of results

Wed, 06/04/2014 - 06:06

I try to give a rôle if a user has more than N succesfull orders.

When I try to add the condition "Check number of results returned by a VBO View" there is an Ajax error that does not show anything but a 500 error.

In the log the only messages I have is : ajax|.../system/ajax|.../admin/config/workflow/rules/reaction/manage/rules_new_role_for_user_if_enough_completed_orders/add/2/condition|1||Invalid form POST data.

I use Commerce 1.9, VBO 3.2, I don't use commerce_vbo_views

Any idea ?

Categories: Issue Queues